-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More detailed info in ContentNotFound exception #10089 #10098
Conversation
modules/core/core-api/src/main/java/com/enonic/xp/content/ContentNotFoundException.java
Fixed
Show fixed
Hide fixed
modules/core/core-api/src/main/java/com/enonic/xp/content/ContentNotFoundException.java
Fixed
Show fixed
Hide fixed
modules/core/core-api/src/main/java/com/enonic/xp/content/ContentNotFoundException.java
Fixed
Show fixed
Hide fixed
modules/core/core-api/src/main/java/com/enonic/xp/content/ContentNotFoundException.java
Fixed
Show fixed
Hide fixed
modules/core/core-api/src/main/java/com/enonic/xp/content/ContentNotFoundException.java
Fixed
Show fixed
Hide fixed
...ortal-impl/src/test/java/com/enonic/xp/portal/impl/url/PortalUrlServiceImpl_pageUrlTest.java
Fixed
Show fixed
Hide fixed
modules/core/core-api/src/main/java/com/enonic/xp/content/ContentNotFoundException.java
Fixed
Show fixed
Hide fixed
modules/portal/portal-impl/src/main/java/com/enonic/xp/portal/impl/url/ImageUrlBuilder.java
Fixed
Show fixed
Hide fixed
...l-impl/src/test/java/com/enonic/xp/portal/impl/url/PortalUrlServiceImpl_processHtmlTest.java
Outdated
Show resolved
Hide resolved
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #10098 +/- ##
============================================
- Coverage 84.20% 84.17% -0.04%
+ Complexity 19328 19324 -4
============================================
Files 2585 2585
Lines 67575 67651 +76
Branches 5396 5396
============================================
+ Hits 56901 56942 +41
- Misses 8036 8071 +35
Partials 2638 2638
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
…impl/url/PortalUrlServiceImpl_processHtmlTest.java Co-authored-by: anatol-sialitski <53557255+anatol-sialitski@users.noreply.github.com>
...re/core-schema/src/main/java/com/enonic/xp/core/impl/schema/content/BuiltinContentTypes.java
Outdated
Show resolved
Hide resolved
…/schema/content/BuiltinContentTypes.java
...l-impl/src/test/java/com/enonic/xp/portal/impl/url/PortalUrlServiceImpl_processHtmlTest.java
Outdated
Show resolved
Hide resolved
...l-impl/src/test/java/com/enonic/xp/portal/impl/url/PortalUrlServiceImpl_processHtmlTest.java
Outdated
Show resolved
Hide resolved
...ortal-impl/src/test/java/com/enonic/xp/portal/impl/url/PortalUrlServiceImpl_pageUrlTest.java
Outdated
Show resolved
Hide resolved
...rtal-impl/src/test/java/com/enonic/xp/portal/impl/url/PortalUrlServiceImpl_imageUrlTest.java
Outdated
Show resolved
Hide resolved
...rtal-impl/src/test/java/com/enonic/xp/portal/impl/url/PortalUrlServiceImpl_imageUrlTest.java
Outdated
Show resolved
Hide resolved
…impl/url/PortalUrlServiceImpl_processHtmlTest.java
…impl/url/PortalUrlServiceImpl_processHtmlTest.java
…impl/url/PortalUrlServiceImpl_pageUrlTest.java
…impl/url/PortalUrlServiceImpl_imageUrlTest.java
...l-impl/src/test/java/com/enonic/xp/portal/impl/url/PortalUrlServiceImpl_processHtmlTest.java
Outdated
Show resolved
Hide resolved
...rtal-impl/src/test/java/com/enonic/xp/portal/impl/url/PortalUrlServiceImpl_imageUrlTest.java
Outdated
Show resolved
Hide resolved
…impl/url/PortalUrlServiceImpl_processHtmlTest.java
…impl/url/PortalUrlServiceImpl_imageUrlTest.java
This is all fixed by generating log-ref for the frontend, possible to find in logs. ContentNotFound contains much more information that helps to identify the repository.
Additionally many log statements were reviewed for correct logging of stacktraces