Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More detailed info in ContentNotFound exception #10089 #10098

Merged
merged 10 commits into from
Mar 23, 2023
Merged

Conversation

rymsha
Copy link
Contributor

@rymsha rymsha commented Mar 22, 2023

  • When image is not found warning is logged, but it is not possible to identify in which repository it was looked up
  • When attachment (full image, for instance) is not found no warning message is logged.
  • Frontend receives a bit too much info in the error url

This is all fixed by generating log-ref for the frontend, possible to find in logs. ContentNotFound contains much more information that helps to identify the repository.

Additionally many log statements were reviewed for correct logging of stacktraces

@rymsha rymsha marked this pull request as ready for review March 22, 2023 15:37
@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Patch coverage: 71.20% and project coverage change: -0.04 ⚠️

Comparison is base (1ba1184) 84.20% compared to head (f07dde7) 84.17%.

❗ Current head f07dde7 differs from pull request most recent head 4f058f8. Consider uploading reports for the commit 4f058f8 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #10098      +/-   ##
============================================
- Coverage     84.20%   84.17%   -0.04%     
+ Complexity    19328    19324       -4     
============================================
  Files          2585     2585              
  Lines         67575    67651      +76     
  Branches       5396     5396              
============================================
+ Hits          56901    56942      +41     
- Misses         8036     8071      +35     
  Partials       2638     2638              
Impacted Files Coverage Δ
...om/enonic/xp/app/ApplicationNotFoundException.java 0.00% <0.00%> (ø)
...in/java/com/enonic/xp/exception/BaseException.java 77.77% <ø> (ø)
...m/enonic/xp/exception/InitializationException.java 0.00% <0.00%> (ø)
...ava/com/enonic/xp/exception/NotFoundException.java 50.00% <ø> (ø)
.../java/com/enonic/xp/exception/SystemException.java 100.00% <ø> (ø)
.../src/main/java/com/enonic/xp/init/Initializer.java 85.71% <0.00%> (ø)
...nonic/xp/security/IdProviderNotFoundException.java 0.00% <0.00%> (ø)
...onic/xp/security/auth/AuthenticationException.java 25.00% <ø> (ø)
.../src/main/java/com/enonic/xp/xml/XmlException.java 30.00% <ø> (ø)
...n/java/com/enonic/xp/xml/parser/XmlFormMapper.java 93.04% <0.00%> (ø)
... and 32 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

…impl/url/PortalUrlServiceImpl_processHtmlTest.java

Co-authored-by: anatol-sialitski <53557255+anatol-sialitski@users.noreply.github.com>
rymsha added 4 commits March 23, 2023 12:01
…impl/url/PortalUrlServiceImpl_processHtmlTest.java
…impl/url/PortalUrlServiceImpl_processHtmlTest.java
…impl/url/PortalUrlServiceImpl_pageUrlTest.java
…impl/url/PortalUrlServiceImpl_imageUrlTest.java
rymsha added 2 commits March 23, 2023 12:03
…impl/url/PortalUrlServiceImpl_processHtmlTest.java
…impl/url/PortalUrlServiceImpl_imageUrlTest.java
@rymsha rymsha merged commit d869599 into master Mar 23, 2023
@rymsha rymsha deleted the issue-10089 branch March 23, 2023 11:04
rymsha added a commit that referenced this pull request Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants