Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMYK JPEG images fail to render #10149 #10150

Merged
merged 1 commit into from
May 30, 2023

Conversation

rymsha
Copy link
Contributor

@rymsha rymsha commented May 26, 2023

No description provided.

@rymsha rymsha linked an issue May 26, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Patch coverage: 55.55% and project coverage change: -0.01 ⚠️

Comparison is base (a23d201) 84.35% compared to head (f34511e) 84.35%.

❗ Current head f34511e differs from pull request most recent head 31b1f25. Consider uploading reports for the commit 31b1f25 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #10150      +/-   ##
============================================
- Coverage     84.35%   84.35%   -0.01%     
- Complexity    19459    19460       +1     
============================================
  Files          2598     2598              
  Lines         67800    67806       +6     
  Branches       5396     5397       +1     
============================================
+ Hits          57194    57197       +3     
- Misses         7986     7988       +2     
- Partials       2620     2621       +1     
Impacted Files Coverage Δ
...om/enonic/xp/core/impl/image/ImageServiceImpl.java 66.43% <55.55%> (-0.71%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rymsha rymsha force-pushed the 10149-cmyk-jpeg-images-fail-to-render branch from f34511e to 02de9a5 Compare May 30, 2023 12:16
@rymsha rymsha force-pushed the 10149-cmyk-jpeg-images-fail-to-render branch from 02de9a5 to 31b1f25 Compare May 30, 2023 12:17
@@ -154,4 +154,19 @@

assertDoesNotThrow( () -> imageService.readImage( readImageParams ) );
}

@Test
public void readImage_cmyk()

Check notice

Code scanning / Pmd (reported by Codacy)

The JUnit 5 test method name 'readImage_cmyk' doesn't match '[a-z][a-zA-Z0-9]*'

The JUnit 5 test method name 'readImage_cmyk' doesn't match '[a-z][a-zA-Z0-9]*'
@rymsha rymsha merged commit 8ae37f0 into master May 30, 2023
@rymsha rymsha deleted the 10149-cmyk-jpeg-images-fail-to-render branch May 30, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Basic support for CMYK JPEG images
3 participants