Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blobstore can throw FileAlreadyExistsException #10447 #10831

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

rymsha
Copy link
Contributor

@rymsha rymsha commented Dec 23, 2024

  • catche FileAlreadyExistsException, to allow NodeVersions with the same blob-keys to be created in parallel.
  • CachedBlobStore refactored to minimize memory impact of not cached records
  • verify integrity of blobs to be cached - by checking blobkey corresponds with blob content.
  • because cache is shared between repositories, cache invalidation on blob deletion is removed
  • NodeVersionService refactored to report exact failed blob load

Additionaly flob file last-modified update removed to avoid concurrent file writes entirely. Blob last-modified has no big value anyway and may be harmful.

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 83.56164% with 12 lines in your changes missing coverage. Please review.

Project coverage is 84.51%. Comparing base (f71fde8) to head (f592349).
Report is 15 commits behind head on 7.15.

Files with missing lines Patch % Lines
...c/xp/internal/blobstore/cache/CachedBlobStore.java 76.00% 5 Missing and 1 partial ⚠️
.../xp/repo/impl/node/dao/NodeVersionServiceImpl.java 89.74% 3 Missing and 1 partial ⚠️
...onic/xp/internal/blobstore/file/FileBlobStore.java 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               7.15   #10831   +/-   ##
=========================================
  Coverage     84.51%   84.51%           
+ Complexity    19629    19623    -6     
=========================================
  Files          2608     2607    -1     
  Lines         68292    68288    -4     
  Branches       5435     5436    +1     
=========================================
- Hits          57718    57715    -3     
+ Misses         7937     7934    -3     
- Partials       2637     2639    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rymsha rymsha marked this pull request as ready for review December 23, 2024 13:19
@rymsha rymsha merged commit bb854e1 into 7.15 Dec 23, 2024
5 of 6 checks passed
@rymsha rymsha deleted the 10447-blobstore-can-throw-filealreadyexistsexception branch December 23, 2024 14:46
rymsha added a commit that referenced this pull request Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants