-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve 'Setting up scheduled job ...' log message #93
Improve 'Setting up scheduled job ...' log message #93
Comments
@pawelkaczor Feel free to submit a PR for this and I'll look at it. |
@pawelkaczor I saw that you've commited your suggestion about one year ago. Dis you finished? I think it would be relevant for the community. |
@felipebonezi Please see discussion: #94 I created new PR (the same implementation as in previous, rejected PR): #110 @enragedginger please reopen this issue. It was closed by mistake. |
@felipebonezi Per my review on #94 I still don't think we should merge this (#110) in. As @pawelkaczor mentioned in the PR, merging this PR results in the addition of a number of new dependencies. This will result in unnecessary bloat for our users and potential headaches if they require different versions of these dependencies. Joda and commons-lang are very common, so I'd be surprised if no one ran into conflicts here. Supposing users want to print out cron expressions for their jobs in some readable format, there are a number of other options that exist. Most promising is that the cron If for some reason that doesn't work, then perhaps we could add a general More generally though, we could update the library to take an @felipebonezi @pawelkaczor What are your thoughts on this? |
@enragedginger Publishing events seems as a good idea, but IMO is quite a different story. Here we are dealing with a concrete and simple issue - the log message:
And I'm offering a solution that solves this problem very well (from a "user" perspective). But of course your concerns regarding incorporation of new dependencies are valid! That's why I suggested to create a new module. Anyway, IMO we should concentrate on fixing the log message. The minimal solution is the removal of " with 'com.typesafe.akka.extension.quartz.QuartzCronSchedule@35876530'" |
Currently the following message is logged (for each schedule entry):
12:24:09,037 INFO [QuartzSchedulerExtension] Setting up scheduled job 'TestJob', with 'com.typesafe.akka.extension.quartz.QuartzCronSchedule@35876530'
The message is not very useful.
In my project I produce the following log message:
12:24:09,035 INFO [PeriodicJobScheduling] Job 'TestJob' will be triggered at 03:01, timezone: Europe/Berlin, calendar: not defined
that contains cron expression description, timezone and calendar (if defined).
The text was updated successfully, but these errors were encountered: