Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to display and index music files by their filename #439

Closed
CodeCubeNeo opened this issue Jul 14, 2022 · 12 comments
Closed

Add an option to display and index music files by their filename #439

CodeCubeNeo opened this issue Jul 14, 2022 · 12 comments
Assignees
Labels
bug Something isn't working improvement question Further information is requested

Comments

@CodeCubeNeo
Copy link

I think it would help users who have local music files that have weird metadata titles, that they can see and search those music files in the app by their filename (filename in the filesystem). There could be an option in the setting to display and index songs by filename instead of the title. An example app that has this feature is the simple music player from simple mobile tools

@enricocid
Copy link
Owner

enricocid commented Jul 14, 2022

This feature is already available. If selected the songs list in details fragment will be sorted by filename instead of title 😆😊

Screenshot_20220714-113741_MPGO_debug

@CodeCubeNeo
Copy link
Author

Yes, but when I try to search for a song with its filename it is not found. That's what i meant by index (i didn't know how to say it better). I can only search for the song's metadata title.

@enricocid
Copy link
Owner

Ok, understood :)
Gonna check simple mp too, thanks :)

@CodeCubeNeo
Copy link
Author

I saw that simple mp also doesnt fully solve that problem. It doesnt show the filename always

enricocid added a commit that referenced this issue Jul 16, 2022
Related to #439

Signed-off-by: enricocid <enrico2588@gmail.com>
@enricocid
Copy link
Owner

Just fixed songs filtering. Now it filters by file name instead of title when the option is selected. That was a bug.
Let me know if I can improve the option further.

@CodeCubeNeo
Copy link
Author

I think that is exatly what i meant. Really awesome and thank you many times. Now we wait for the new release ;).

@enricocid
Copy link
Owner

Just pushed the update. If the problem is fixed don't forget to close this issue :) thanks

@enricocid enricocid added bug Something isn't working question Further information is requested improvement and removed feature request labels Jul 28, 2022
@CodeCubeNeo
Copy link
Author

This is now fixed and now I can finally search by the filename ;). But now i cant search for the song by its metadata filename (idk if that is intended). Also there is one other weird thing, when i click the song to play the playing screen is displaying the metadata title, not the filename even with song visualisation: filename option selected.

@enricocid
Copy link
Owner

  1. I can show both results (filename + metadata title) if you want
  2. Yeah, that is intended. I can change it too in next update.
    Let me know 😉

@CodeCubeNeo
Copy link
Author

Well i guess if the option "song visualisation" is set to filename it should display it in the playing now screen with the filename right?

enricocid added a commit that referenced this issue Aug 2, 2022
Signed-off-by: enricocid <enrico2588@gmail.com>
@enricocid
Copy link
Owner

enricocid commented Aug 2, 2022

This issue should be fixed now. You can try the debug apk that will be available here (at the bottom) once the build process has finished :)

@enricocid
Copy link
Owner

This one should be fixes now. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working improvement question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants