Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strings reworked #227

Merged
merged 1 commit into from
Nov 14, 2020
Merged

Strings reworked #227

merged 1 commit into from
Nov 14, 2020

Conversation

comradekingu
Copy link
Contributor

No description provided.

@enricocid enricocid merged commit 32d80ab into enricocid:main Nov 14, 2020
@enricocid
Copy link
Owner

Thank You. Great improvements. 👍🏻 :)

@RickyM7
Copy link
Contributor

RickyM7 commented Nov 14, 2020

@enricocid The "Turn On" and "Turn Off" options have to be inverted or else things will get confusing.

@enricocid
Copy link
Owner

@enricocid The "Turn On" and "Turn Off" options have to be inverted or else things will get confusing.

You are right.
error_no_browser too was wrong as this string is referred to web browsers

Anyway I've fixed :) Thanks

@RickyM7
Copy link
Contributor

RickyM7 commented Nov 14, 2020

I think in the string <string name="loved_song_remove">%1s (%2s) will be deleted from loved songs. Continue?</string> the "deleted" can be changed by "removed" as well.

@comradekingu
Copy link
Contributor Author

@RickyM7 Are you sure I don't have it right with the off and on?
Now it is in sequence, and according to what the key says for each string.

@RickyM7
Copy link
Contributor

RickyM7 commented Nov 14, 2020

@comradekingu The point is that it is in the legend of the option, saying what will happen if we click on it, for example, if the option "Audio Focus" is enabled, the legend will be, Turn Off Audio Focus Management", which is what will happen if you click the option.
Note: sorry for my bad english, I hope you can understand what I wanted to say.

@enricocid
Copy link
Owner

@RickyM7 Are you sure I don't have it right with the off and on?
Now it is in sequence, and according to what the key says for each string.

https://material.io/design/platform-guidance/android-settings.html#label-and-secondary-text

You can:
1. Explain what happens when a setting is enabled or disabled.
2. or describe the current status

The first is the simpler one (description of the status are generally too wordy)

See the Bluetooth example :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants