-
-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing option to sort music by date added #263
Conversation
e: /home/runner/work/Music-Player-GO/Music-Player-GO/project/app/src/main/java/com/iven/musicplayergo/helpers/ListsHelper.kt: (142, 35): Unresolved reference: dateAdded |
Thanks, but next time use commit -amend and push force instead of adding new commits 😉👍🏻 |
Seems like you have imported Music Player Go root folder.
You have to import the project folder 😉
I don't have any particular config.
For date feature. I think this feature will apply only to the music tab.
Music from albums/folder should present the same date 😉
So just add this option to music tab, the rest of the impl should be ok 👍🏻 write a
new commit, don't amend this one.
PS in the commit message write what you're going to implement not "initial
implementation" 😜
|
There's a couple of things left to iron out here.
|
I'm comparing with Files and it seems sorting is wrong :) |
I've changed the sorting method to use |
Thanks! It would be nice if You could send me a more clean pull request (fork again the project, make changes and create pull request) :) |
This should resolve #231
Testing is to be done.
Please point out any obvious flaws you see as I'm a complete beginner.