Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing option to sort music by date added #263

Closed
wants to merge 7 commits into from
Closed

Implementing option to sort music by date added #263

wants to merge 7 commits into from

Conversation

vtkhatri
Copy link
Contributor

This should resolve #231
Testing is to be done.
Please point out any obvious flaws you see as I'm a complete beginner.

@enricocid
Copy link
Owner

e: /home/runner/work/Music-Player-GO/Music-Player-GO/project/app/src/main/java/com/iven/musicplayergo/helpers/ListsHelper.kt: (142, 35): Unresolved reference: dateAdded

@enricocid
Copy link
Owner

Thanks, but next time use commit -amend and push force instead of adding new commits 😉👍🏻

@vtkhatri
Copy link
Contributor Author

It builds now but does not work XD.
Will try after some debugging.

I didn't know you could commit -amend, I'll see if I can hide my mistakes like that ;P.

In the meantime can you please show me what configuration you use to build and test?
temp

Thanks in advance.

@enricocid
Copy link
Owner

enricocid commented Jan 25, 2021 via email

@vtkhatri
Copy link
Contributor Author

There's a couple of things left to iron out here.

  1. It's added to all tabs - have to limit it to Music tab
  2. The sorting is not 100% reliable - it measures time in seconds from 1970, but misses some newly added files.

@enricocid
Copy link
Owner

I'm comparing with Files and it seems sorting is wrong :)

@vtkhatri
Copy link
Contributor Author

vtkhatri commented Feb 5, 2021

I've changed the sorting method to use DATE_MODIFIED instead of DATE_ADDED.
Please verify from your end, it's working as expected now.

@enricocid
Copy link
Owner

Thanks! It would be nice if You could send me a more clean pull request (fork again the project, make changes and create pull request) :)

@vtkhatri vtkhatri closed this Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sorting music by New or Last Added
2 participants