Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues related to sRGB correct rendering #140

Open
ensisoft opened this issue Jan 27, 2023 · 1 comment
Open

Fix issues related to sRGB correct rendering #140

ensisoft opened this issue Jan 27, 2023 · 1 comment
Labels
editor graphics

Comments

@ensisoft
Copy link
Owner

ensisoft commented Jan 27, 2023 •
edited

  • The color picker used by the editor is likely giving us back sRGB encoded color values. These need to be converted into linear before being used for any computation or passed onto shaders.
@ensisoft
Copy link
Owner Author

ensisoft commented Sep 30, 2023 •
edited

  • Make sure to convert any "color" (vec4) uniform from sRGB to linear.
  • Change default texture color space from Linear to sRGB
  • Make sure the color buffer writes works properly (in case the color buffer is sRGB)
  • Remove the useless gamma value from materials
  • Clear value in glClearColor
  • Read values in glReadPixels (screenshot functionality)

ensisoft added a commit that referenced this issue Sep 30, 2023
@ensisoft
Update the sRGB test cases in the graphics test app
6815941 
Update the sRGB test cases in the graphics test app and document
the findings in graphics/README.md.

- The sRGB default frame buffer test now "makes sense" with the
  conclusion that the implementation doesn't do correct sRGB
  conversion for the gl_FragColor values.

- The sRGB texture test works as expected.

Issue #140
ensisoft added a commit that referenced this issue Sep 30, 2023
@ensisoft
Update the sRGB test cases in the graphics test app
a32ac67 
Update the sRGB test cases in the graphics test app and document
the findings in graphics/README.md.

- The sRGB default frame buffer test now "makes sense" with the
  conclusion that the implementation doesn't do correct sRGB
  conversion for the gl_FragColor values.

- The sRGB texture test works as expected.

Issue #140
@ensisoft ensisoft changed the title Fix issues related to sRGB encoded color picking Fix issues related to sRGB correct rendering Oct 3, 2023
ensisoft added a commit that referenced this issue Oct 24, 2023
@ensisoft
Add base Color4f sRGB encode/decode utility functions
396125e 
Add base Color4f sRGB encode/decode utility functions.

Issue #140
ensisoft added a commit that referenced this issue Oct 24, 2023
@ensisoft
Add base Color4f sRGB encode/decode utility functions
2ab34f1 
Add base Color4f sRGB encode/decode utility functions.

Issue #140
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
editor graphics
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ensisoft