Skip to content

Commit

Permalink
Apply first review
Browse files Browse the repository at this point in the history
  • Loading branch information
farmaazon committed Nov 22, 2024
1 parent 52f14e9 commit 3921427
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ tsconfig.json

# GUI/Dashboard
/app @Frizi @farmaazon @vitvakatu @kazcw @AdRiley @PabloBuchu @indiv0 @somebody1234 @MrFlashAccount
/app/gui/e2e/dashboard @PabloBuchu @indiv0 @somebody1234 @MrFlashAccount
/app/gui/e2e/project-view @Frizi @farmaazon @vitvakatu @kazcw @AdRiley
/app/gui/integration-test/dashboard @PabloBuchu @indiv0 @somebody1234 @MrFlashAccount
/app/gui/integration-test/project-view @Frizi @farmaazon @vitvakatu @kazcw @AdRiley
/app/gui/src/dashboard @PabloBuchu @indiv0 @somebody1234 @MrFlashAccount
/app/gui/src/project-view @Frizi @farmaazon @vitvakatu @kazcw @AdRiley
/app/ide-desktop/ @PabloBuchu @indiv0 @somebody1234 @MrFlashAccount
Expand Down
2 changes: 1 addition & 1 deletion app/ide-desktop/client/tests/localWorkflow.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ electronTest('Local Workflow', async ({ page, app, projectsDir }) => {
await expect(writeNode.locator('.TableVisualization')).toContainText(OUTPUT_FILE)
} catch {
// TODO[ao]
// The above check is flaky, because sometimes the additional egine run overrides node output back to "dry run".
// The above check is flaky, because sometimes the additional engine run overrides node output back to "dry run".
// To confirm if this should be expected.
console.error(
'Didn\'t see the visualization update after "Write once" action; assuming it\'s already done',
Expand Down

0 comments on commit 3921427

Please sign in to comment.