Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve to_display_text for errors #10770

Closed
hubertp opened this issue Aug 6, 2024 · 4 comments · Fixed by #11025
Closed

Improve to_display_text for errors #10770

hubertp opened this issue Aug 6, 2024 · 4 comments · Fixed by #11025
Assignees
Labels
-compiler -libs Libraries: New libraries to be implemented

Comments

@hubertp
Copy link
Collaborator

hubertp commented Aug 6, 2024

Issues like #10750 are horrible to debug with a plain error atom name, e.g. No_Such_Method.

@hubertp hubertp added -compiler -libs Libraries: New libraries to be implemented labels Aug 6, 2024
@github-project-automation github-project-automation bot moved this to ❓New in Issues Board Aug 6, 2024
@jdunkerley jdunkerley self-assigned this Aug 14, 2024
@jdunkerley
Copy link
Member

Reviewed the No_Such_Method type. It has the to_display_text properly set up.
I'm guessing it is an issue in engine/runtime/src/main/java/org/enso/interpreter/runtime/error/PanicException.java as to why the Java Exception is not showing the display text.

It looks like computeMessage will attempt to call the to_display_text via the InteropLibrary and fall back to the type name if it doesn't exist.

@jdunkerley jdunkerley assigned hubertp and unassigned jdunkerley Aug 14, 2024
@JaroslavTulach
Copy link
Member

How exactly do we plan to tackle this issue?

it is an issue in engine/runtime/src/main/java/org/enso/interpreter/runtime/error/PanicException.java as to why the Java Exception is not showing the display text.
computeMessage will attempt to call the to_display_text via the InteropLibrary and fall back to the type name if it doesn't exist.

Are we supposed to dump more info when such a situation happens?

@JaroslavTulach JaroslavTulach moved this from 📤 Backlog to 👁️ Code review in Issues Board Sep 10, 2024
@enso-bot
Copy link

enso-bot bot commented Sep 11, 2024

Jaroslav Tulach reports a new STANDUP for yesterday (2024-09-10):

Progress: .

Discord
Discord is great for playing games and chilling with friends, or even building a worldwide community. Customize your own space to talk, play, and hang out.

@mergify mergify bot closed this as completed in #11025 Sep 11, 2024
mergify bot pushed a commit that referenced this issue Sep 11, 2024
Closes #10770 by dumping out more information when `to_display_text` invocations fails.
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Sep 11, 2024
@enso-bot
Copy link

enso-bot bot commented Sep 11, 2024

Jaroslav Tulach reports a new STANDUP for today (2024-09-11):

Progress: .

Google Docs
Fun-(ctional) programming with Truffle & Enso.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-compiler -libs Libraries: New libraries to be implemented
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants