Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sporadic no data in visualizations on startup #11189

Closed
hubertp opened this issue Sep 26, 2024 · 6 comments
Closed

Sporadic no data in visualizations on startup #11189

hubertp opened this issue Sep 26, 2024 · 6 comments
Assignees
Labels
--regression Important: regression -gui p-high Should be completed in the next sprint

Comments

@hubertp
Copy link
Collaborator

hubertp commented Sep 26, 2024

On startup, some nodes which have visualizations attached may show no data.
Surprisingly, when detached and attached again, data will magically re-appear.

Screenshot from 2024-09-26 16-14-32

@hubertp hubertp added p-medium Should be completed in the next few sprints -language-server labels Sep 26, 2024
@hubertp hubertp self-assigned this Sep 26, 2024
@hubertp hubertp added p-high Should be completed in the next sprint -gui --regression Important: regression and removed p-medium Should be completed in the next few sprints -language-server labels Sep 26, 2024
@hubertp
Copy link
Collaborator Author

hubertp commented Sep 26, 2024

Steps to reproduce:

  • setup a project with a couple of nodes
  • attach visualization to a large number of nodes (~8-10)
  • close the project
  • open the project

I bisected GUI and found the culprit to be #11077, @kazcw.
Parent commit 3f748fd works fine, a8810e1 consistently shows "No Rows To Show" for a number of nodes. Also, I noticed a significant increase in the number of {attach,modify}Visualization requests, some of which don't really make sense to me.

@hubertp hubertp assigned kazcw and unassigned hubertp Sep 26, 2024
@kazcw
Copy link
Contributor

kazcw commented Sep 26, 2024

@hubertp, I'm not able to reproduce this with the provided "New Project 1 test standups". I have also tried enabling a larger number of visualizations, and I'm still not seeing the failure to load. I also measured {attach,modify}Visualization and did not find a difference; I'm seeing 37 attachVisualization calls and 8 modifyVisualization calls, whether testing the commit before #11077 was merged or current develop (849622e).
The steps to reproduce are also effective steps to reproduce #11121. Since that is an Undefined Behavior bug that is triggered mostly during compilation of visualization expressions, the observed behavior is consistent with this known bug. Let's re-examine this if it occurs when using a backend with #11121 fixed.

@kazcw kazcw closed this as not planned Won't fix, can't repro, duplicate, stale Sep 26, 2024
@github-project-automation github-project-automation bot moved this from ❓New to 🟢 Accepted in Issues Board Sep 26, 2024
@hubertp
Copy link
Collaborator Author

hubertp commented Sep 27, 2024

I'm not the only one who has experienced this. I believe @jdunkerley has also seen those.
I'm testing with a fixed latest backend on develop (849622e) and varies only in GUI versions and I have this problem 100% consistently.
I do not believe this has anything to do with #11121 - there are 0 parser warnings/failures in the logs.
Have you tried with dev build (via browser not electron)?
Also, backend sends visualization updates correctly as I see in the logs, it is GUI which somehow ignores the data.

@hubertp hubertp reopened this Sep 27, 2024
@github-project-automation github-project-automation bot moved this from 🟢 Accepted to ❓New in Issues Board Sep 27, 2024
@hubertp
Copy link
Collaborator Author

hubertp commented Sep 27, 2024

I will do more regression testing then.
Kazam_screencast_00010.webm

@kazcw
Copy link
Contributor

kazcw commented Oct 3, 2024

849622e is before the fix (#11147) was merged in 2891981. Warnings/failures are not necessarily expected due to #11121; the parser output (and thus visualization data) could simply be wrong. I would make sure this occurs after 2891981 before spending much time on it.

@hubertp
Copy link
Collaborator Author

hubertp commented Dec 30, 2024

Can't seem to reproduce the problem anymore. There have been a couple of improvements in that area, and visualizations in general should be improved (on the backend side) with #10525

@hubertp hubertp closed this as completed Dec 30, 2024
@github-project-automation github-project-automation bot moved this from ❓New to 🟢 Accepted in Issues Board Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--regression Important: regression -gui p-high Should be completed in the next sprint
Projects
Status: 🟢 Accepted
Development

No branches or pull requests

2 participants