Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New visualization UI API #11077

Merged
merged 9 commits into from
Sep 23, 2024
Merged

New visualization UI API #11077

merged 9 commits into from
Sep 23, 2024

Conversation

kazcw
Copy link
Contributor

@kazcw kazcw commented Sep 14, 2024

Pull Request Description

  • Improve visualization UI APIs:
    • Isolate visualizations within a Vue Custom Element to prevent any unintended interaction between GUI and visualization CSS/JS.
    • New visualization-menus API: Visualizations no longer create toolbars using the GUI's components; a simpler JS interface moves the responsibility for appearance of controls to the GUI.
    • Simplify visualization configuration interface. Properties that should not be exposed to visualizations have been removed. Visualizations no longer need logic implementing fullscreen mode; the size property reflects the current renderable area.
    • Visualizations no longer use a VisualizationContainer; the visualization simply renders its content at its root.
  • Viz dropdowns: Buttons always show arrows (fixes Add dropdown indicator arrows to the table Viz menu buttons #10809)
  • Fullscreen mode: Fix rendering size of scatter plot and other visualizations
  • JSON visualization interactivity: Fix intermittent incorrectly non-interactive state
  • Viz toolbars: Fix squished-looking rightmost button.

Other API changes:

  • Interaction no longer includes GraphNavigator with pointer events.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.

@kazcw kazcw self-assigned this Sep 14, 2024
@kazcw kazcw added the CI: No changelog needed Do not require a changelog entry for this PR. label Sep 14, 2024
@kazcw
Copy link
Contributor Author

kazcw commented Sep 20, 2024

@Frizi The other side of viz API improvement is the static-API change we talked about, but I think that change will mostly affect different code from this, so let's merge this separately since it contains API changes and several bugfixes.

@kazcw kazcw marked this pull request as ready for review September 20, 2024 02:46
@kazcw kazcw changed the title New visualization rendering API New visualization UI API Sep 20, 2024
<span v-text="props.data.error.message"></span>
</div>
<div class="LoadingErrorVisualization">
<div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably don't need the inner div anymore.

@kazcw kazcw added the CI: Ready to merge This PR is eligible for automatic merge label Sep 23, 2024
@mergify mergify bot merged commit a8810e1 into develop Sep 23, 2024
37 checks passed
@mergify mergify bot deleted the wip/kw/viz-ui-api branch September 23, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add dropdown indicator arrows to the table Viz menu buttons
2 participants