Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure disable private check cmd line option disables runtime private access checks #10034

Merged

Conversation

Akirathan
Copy link
Member

@Akirathan Akirathan commented May 22, 2024

Fixes #9882

Pull Request Description

Ensure that --disable-private-check cmd line option disables the runtime private access checks as well. So far, only private constructor invocations are checked.

Important Notes

Polyglot (foreign) code still cannot see private members of Enso objects, even when private checks are disabled. The --disable-private-check cmd line option shall work only for Enso code. Let's keep the private members of Enso objects hidden for the foreign polyglot code.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.

@Akirathan Akirathan self-assigned this May 22, 2024
@Akirathan Akirathan added the CI: No changelog needed Do not require a changelog entry for this PR. label May 22, 2024
@Akirathan Akirathan marked this pull request as ready for review May 22, 2024 12:25
@Akirathan Akirathan merged commit ba2787c into develop May 22, 2024
36 checks passed
@Akirathan Akirathan deleted the wip/akirathan/9882-fix-disable-private-check-cmdline-opt branch May 22, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The private constructor does not respect the --disable-private-check option
2 participants