Extension methods can be exported by name #10274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akirathan
added
the
CI: No changelog needed
Akirathan
force-pushed
the
wip/akirathan/10258-no-export-all
branch
from
09314ba to
ae066c3
Compare
Akirathan
force-pushed
the
wip/akirathan/10258-no-export-all
branch
from
ae066c3 to
994b912
Compare
# Conflicts: # engine/runtime-compiler/src/main/scala/org/enso/compiler/pass/analyse/BindingAnalysis.scala # engine/runtime-integration-tests/src/test/scala/org/enso/compiler/test/pass/analyse/BindingAnalysisTest.scala # engine/runtime/src/main/java/org/enso/interpreter/caches/ImportExportCache.java
| return CollectionConverters.asJava(mod.getBindingsMap().definedEntities()); | ||
| } | ||
|
|
||
| private static Map<String, List<ResolvedName>> getExportedSymbols(Module module) { |
There was a problem hiding this comment.
This method looks almost like a useful production code. module.getExportedSymbols would make same sense too.
Fix some tests in ExtensionMethodResolutionTest
…ed ambiguous if they have the same name
|
There are four compilation failures IrUtilsTest. |
JaroslavTulach
approved these changes
Jun 21, 2024
Co-authored-by: Jaroslav Tulach <jaroslav.tulach@enso.org>
4e6
approved these changes
Jun 25, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part of #10258 - extension methods can be exported by name
Pull Request Description
Ultimately, we want to forbid the
from ... export allsyntax. This PR starts by providing a way to explicitly export extension and conversion methods by name.Stdlib code will be modified in upcoming PR.
Important Notes
A single name can refer to multiple extension or conversion methods. Exports are not qualified. For example,
will export both
My_Type.ext_methodandOther_Type.ext_method.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.