Align Enso launcher with Truffle's AbstractLanguageLauncher #10335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaroslavTulach
commented
Jul 2, 2024
| @@ -2517,6 +2517,7 @@ lazy val `engine-runner` = project | |||
| commands += WithDebugCommand.withDebug, | |||
| inConfig(Compile)(truffleRunOptionsSettings), | |||
| libraryDependencies ++= Seq( | |||
| "org.graalvm.sdk" % "launcher-common" % graalMavenPackagesVersion, | |||
There was a problem hiding this comment.
Using launcher-common is not easy. It is not a nicely designed API. Rather an abstraction of common functionality found among various Truffle language launchers. Some things aren't even possible/easy - for example get list of unprocessed arguments.
|
Rather than using
|
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Closes #5298 by extending
AbstractLanguageLauncherand thus inheriting all its functionality common for other Truffle language implementations.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,