Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skeletal PanicExceptionTest and more logging when AssertionError happens #11393

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

JaroslavTulach
Copy link
Member

@JaroslavTulach JaroslavTulach commented Oct 24, 2024

Pull Request Description

Closes #11127 by adding more logging when AssertionError happens. Plus adding skeletal PanicExceptionTest that asserts getMessage() works as expected under regular constellations.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • All code follows the
    Java,
  • Unit tests have been written where possible.

@JaroslavTulach JaroslavTulach merged commit 15575b4 into develop Oct 29, 2024
42 checks passed
@JaroslavTulach JaroslavTulach deleted the wip/jtulach/PanicInfo11127 branch October 29, 2024 14:47
@JaroslavTulach
Copy link
Member Author

There is a [CI failure printing out more information] provided by this PR:

 [PanicException]  Cannot compute message for Error Error.type UnresolvedSymbol<==>
 [PanicException]    payload cons: Error
 [PanicException]  Cannot compute message for Error Error.type UnresolvedSymbol<==>
 [PanicException]  Exception location: InvokeMethodNodeGen@3fe14148
 [PanicException]    location source: SourceSection(source=Common.enso [204:19 - 204:54], index=6656, length=36, characters=Meta.type_of self.target == Function)
 [PanicException]    location class: org.enso.interpreter.node.callable.InvokeMethodNodeGen
 [PanicException]    location string: InvokeMethodNodeGen@3fe14148
 [PanicException]    payload class: org.enso.interpreter.runtime.data.atom.BoxingAtom
 [PanicException]    payload cons: Error
 [PanicException]    payload type: No_Such_Method
 [PanicException]  Cannot compute message for Error Error.type UnresolvedSymbol<==>
 [PanicException]  Exception location: InvokeMethodNodeGen@3fe14148
 [PanicException]    location source: SourceSection(source=Common.enso [204:19 - 204:54], index=6656, length=36, characters=Meta.type_of self.target == Function)
 [PanicException]    location class: org.enso.interpreter.node.callable.InvokeMethodNodeGen
 [PanicException]    location string: InvokeMethodNodeGen@3fe14148
 [PanicException]    payload class: org.enso.interpreter.runtime.data.atom.BoxingAtom
 [PanicException]    payload cons: Error
 [PanicException]    payload type: No_Such_Method
 [PanicException]  Cannot compute message for Error Error.type UnresolvedSymbol<==>
 [PanicException]  Exception location: InvokeMethodNodeGen@3fe14148
 [PanicException]    location source: SourceSection(source=Common.enso [204:19 - 204:54], index=6656, length=36, characters=Meta.type_of self.target == Function)
 [PanicException]    location class: org.enso.interpreter.node.callable.InvokeMethodNodeGen
 [PanicException]    location string: InvokeMethodNodeGen@3fe14148
 [PanicException]    payload class: org.enso.interpreter.runtime.data.atom.BoxingAtom
 [PanicException]    payload cons: Error
 [PanicException]    payload type: No_Such_Method
 [PanicException]  Cannot compute message for Error Error.type UnresolvedSymbol<==>
 [PanicException]  Exception location: InvokeMethodNodeGen@3fe14148
 [PanicException]    location source: SourceSection(source=Common.enso [204:19 - 204:54], index=6656, length=36, characters=Meta.type_of self.target == Function)

now we need "just" someone to explain what can that mean...

@Akirathan
Copy link
Member

Akirathan commented Jan 6, 2025

Another example of UnresolvedSymbol<==> failure with the new message at https://github.com/enso-org/enso/actions/runs/12631622328/job/35193723072?pr=11770#step:7:2041

GitHub
Enso Analytics is a self-service data prep and analysis platform designed for data teams. - Generate IR definitions by annotation processor - 1st step · 98476fa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AssertionError with payload Error Error.type UnresolvedSymbol<==> when executing Base_Tests
2 participants