Attempt to fix broken envs during build #11584
Conversation
Frizi
added
the
CI: No changelog needed
Frizi
requested review from
farmaazon,
vitvakatu,
kazcw,
AdRiley,
PabloBuchu,
indiv0,
somebody1234,
MrFlashAccount,
jdunkerley and
hubertp
as code owners
| @@ -6,4 +6,4 @@ required-versions: | |||
| # NB. The Rust version is pinned in rust-toolchain.toml. | |||
| # NB. The Node version is pinned in .node-version. | |||
| cargo-watch: ^8.1.1 | |||
| wasm-pack: ^0.12.1 | |||
| wasm-pack: ">=0.12.1" | |||
There was a problem hiding this comment.
Why this change? Are not afraid of wasm-pack updates even a bit?
There was a problem hiding this comment.
I am using 0.13 and there is no issue with that. Historically they also didn't really make much updates. 0.13 was released a few weeks ago and it was a first release since a few years back. For CI, we pin the installed version anyway. This change just makes the potential compatibility issues with local setup go away, as any new installation will default to 0.13 now. We are phasing out wasm-pack usage completely soon enough anyway.
MrFlashAccount
added
CI: Keep up to date
|
I added the labels above as possible solution for failed storybook deploy task: https://github.com/enso-org/enso/actions/runs/11953657884/job/33322022010?pr=11584 For some reason it doesn't detect the chromatic config which happen on some PRs but doesn't on the others
|
🧪 Storybook is successfully deployed!📊 Dashboard:
|
Frizi
added
CI: Ready to merge
Pull Request Description
Attempt to fix build env issues causing "Enso undefined" version and missing AG grid license key.
Screenshot taken from a CI build:
