Table.input instead of Table.new #11612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitvakatu
requested review from
Frizi,
farmaazon,
kazcw and
AdRiley
as code owners
farmaazon
approved these changes
Nov 21, 2024
CHANGELOG.md
Outdated
Comment on lines
32
to
33
| - [Table Input Widget is now used on Table.input method instead of | ||
| Table.new][11612]. |
There was a problem hiding this comment.
I would explain more for users not accustomed to our libs. Maybe "Table widget is now matched for Table.input code, and the columns are parsed"...
| 'Table.input 14', | ||
| 'Table.input array1', | ||
| "Table.input ['a', [123]]", | ||
| "Table.input [['a', [123]]]", |
There was a problem hiding this comment.
Besides this line, all other cases should have '123' - otherwise we could get false positive (for example, we want to test that we won't match against a column name which is a function call (line 182), but even if the code has a bug and we do match, the test still passes because of number presence.
app/gui/src/project-view/components/GraphEditor/widgets/WidgetTableEditor/tableInputArgument.ts
Show resolved
Hide resolved
| "type": "method", | ||
| "module": "Standard.Table.Table", | ||
| "name": "input", | ||
| "arguments": [], |
There was a problem hiding this comment.
I would put the argument here in case someone in the future would make a test with connecting to input args.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Closes #11434
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.