Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix output edges; add unit and integration testing. #11637

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

kazcw
Copy link
Contributor

@kazcw kazcw commented Nov 22, 2024

Pull Request Description

Fix output edges; add unit and integration testing for output and input edges.

Fixes #11635.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@kazcw kazcw added the CI: No changelog needed Do not require a changelog entry for this PR. label Nov 22, 2024
@kazcw kazcw self-assigned this Nov 22, 2024
@kazcw kazcw marked this pull request as ready for review November 22, 2024 15:56
Copy link

github-actions bot commented Nov 22, 2024

🧪 Storybook is successfully deployed!

📊 Dashboard:

@kazcw kazcw added the CI: Keep up to date Automatically update this PR to the latest develop. label Nov 26, 2024
@kazcw kazcw removed the CI: Keep up to date Automatically update this PR to the latest develop. label Nov 26, 2024
@kazcw kazcw added the CI: Ready to merge This PR is eligible for automatic merge label Nov 26, 2024
@mergify mergify bot merged commit 9ddd841 into develop Nov 26, 2024
52 of 53 checks passed
@mergify mergify bot deleted the wip/kw/fix-output-edges branch November 26, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output nodes have no incoming edges.
2 participants