-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tableVisualisation/typesOnNodeHover tests #11659
Closed
kazcw
wants to merge
5
commits into
wip/kw/fix-teleporter-crash
from
wip/kw/fix-test-expressionupdates
Closed
Fix tableVisualisation/typesOnNodeHover tests #11659
kazcw
wants to merge
5
commits into
wip/kw/fix-teleporter-crash
from
wip/kw/fix-test-expressionupdates
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #11534 - Visualizations are partially transparent by default - The initial z-order is undetermined at the project load - Node is moved on top of other if it is dragged (before it only happened if it was **selected**, which is not the same) - Changed rendering for edges slightly, to avoid visible edge ends underneath visualization. The implementation of additional offsets is rather naive, but it works. https://github.com/user-attachments/assets/fba44816-eed9-471d-83a7-8fe6e5892477
`ydoc-server` compilation requires generation of `ydoc.cjs` resource that can take time and slow down the libraries development (building the enso distribution). This PR splits Ydoc into a library and the server part to avoid JS resources generation during the compilation of the language server. Changelog: - refactor: Ydoc into ~~`ydoc`~~ `ydoc-polyglot` library and `ydoc-server` server parts - update: language server to depend on the ~~`ydoc`~~ `ydoc-polyglot` library
If a data quality metric is added to the array sent in the table viz json for a table/column the metric will be added to the columns tooltip without the need for any frontend/ts changes. This doesn't change anything for the users but here is a screenshot to show the same functionality: ![dqm-enso-driven](https://github.com/user-attachments/assets/7bf83d35-0d63-49ac-8d70-1f86dbedc169)
- Update mock data for multi-type expression updates (#11583)
kazcw
added
the
CI: No changelog needed
Do not require a changelog entry for this PR.
label
Nov 25, 2024
kazcw
requested review from
Frizi,
farmaazon,
vitvakatu and
AdRiley
as code owners
November 25, 2024 23:57
🧪 Storybook is successfully deployed!📊 Dashboard:
|
kazcw
requested review from
jdunkerley,
radeusgd,
GregoryTravis,
marthasharkey,
4e6,
JaroslavTulach,
hubertp and
Akirathan
as code owners
November 26, 2024 01:14
Combined with #11656. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.