Improve Sentry support #11776
Merged
Improve Sentry support #11776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somebody1234
added
CI: No changelog needed
somebody1234
requested review from
PabloBuchu,
indiv0,
MrFlashAccount,
Frizi,
farmaazon,
vitvakatu,
kazcw and
AdRiley
as code owners
🧪 Storybook is successfully deployed!📊 Dashboard:
|
|
@MrFlashAccount ready for re-CR i think |
MrFlashAccount
approved these changes
Dec 16, 2024
|
@somebody1234 let's merge it and see how it goes |
MrFlashAccount
added
the
CI: Ready to merge
jdunkerley
requested changes
Dec 16, 2024
.github/workflows/release.yml
Outdated
| ENSO_CLOUD_STRIPE_KEY: ${{ vars.ENSO_CLOUD_STRIPE_KEY }} | ||
| ENSO_IDE_AG_GRID_LICENSE_KEY: ${{ vars.ENSO_AG_GRID_LICENSE_KEY }} | ||
| ENSO_IDE_MAPBOX_API_TOKEN: ${{ vars.ENSO_MAPBOX_API_TOKEN }} | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| SENTRY_AUTH_TOKEN: ${{ vars.SENTRY_AUTH_TOKEN }} |
There was a problem hiding this comment.
this should be a secret not a var
app/gui/src/dashboard/index.tsx
Outdated
| * authentication/dashboard UI using React. It also handles routing and other interactions (e.g., | ||
| * for redirecting the user to/from the login page). | ||
| */ | ||
| export function run(props: DashboardProps) { | ||
| const { vibrancy, supportsDeepLinks, queryClient, logger } = props | ||
| if ( | ||
| !detect.IS_DEV_MODE && | ||
| // !detect.IS_DEV_MODE && |
|
@jdunkerley should be ready for re-review |
jdunkerley
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Thanks @somebody1234 - let me know what vars/secrets need added to org.
kazcw
approved these changes
Dec 18, 2024
somebody1234
added a commit
that referenced
this pull request
Dec 24, 2024
- Close enso-org/cloud-v2#1590 - Add source maps to built bundle for sentry to pick up - Close enso-org/cloud-v2#1589 - Add global Sentry filter to avoid sending 400 responses from backend - Wrap settings user and organization profile picture inputs in form - Upgrade from deprecated sentry APIs # Important Notes None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Important Notes
None
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
The documentation has been updated, if necessary.Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
Unit tests have been written where possible.If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,or the Snowflake database integration, a run of the Extra Tests has been scheduled.
If applicable, it is suggested to paste a link to a successful run of the Extra Tests.