Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move utility files to common package #11863

Draft
wants to merge 18 commits into
base: develop
Choose a base branch
from
Draft

Move utility files to common package #11863

wants to merge 18 commits into from

Conversation

somebody1234
Copy link
Contributor

@somebody1234 somebody1234 commented Dec 13, 2024 •
edited
Loading

Pull Request Description

  • ⚠️ On hold until Bazel build system #11337 is merged
  • Move codebase-agnostic (non-dashboard-specific) files to common package

Important Notes

  • A lot of files were changed due to the refactoring - however there are no logic changes, so it will probably be easier, when fixing merge conflicts with this commit, to preserve the changes on the branch and simply fix any type errors.

Testing Instructions

N/A. No logic changes present, only moving files.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.~~
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 13, 2024 •
edited
Loading

🧪 Storybook is successfully deployed!

📊 Dashboard:

@Frizi
Copy link
Contributor

Frizi commented Dec 13, 2024

Why is this being moved? We don't need a common module anymore, since we have the projects merged into one. We were slowly moving things from common back to the gui, to remove extra compilation unit from the picture. This PR does the opposite. I'm fine with the general refactorings, but they should land somewhere in app/gui/src.

kazcw
kazcw reviewed Dec 13, 2024
View reviewed changes
app/common/src/utilities/data/__tests__/iterator.test.ts Outdated
Comment on lines 2 to 14

import {
chain,
count as countFn,
empty,
filter,
filterDefined,
last as lastFn,
range,
tryGetSoleValue,
zip,
zipLongest,
} from '../iter'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change? We usually use the iter module by qualified import, because it defines a lot of names that are likely to collide with locals.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh... yeah, my bad. i guess ideally we could record exceptions (?) like these somewhere? just so there's somewhere to refer to when doing refactors

@somebody1234
Copy link
Contributor Author

We don't need a common module anymore, since we have the projects merged into one

💀 oh yeah i forgor. yeah i just wanted to move the stuff out of the dashboard specific tree

@somebody1234
Copy link
Contributor Author

moved from common module to @common (in gui/src/common/ (hopefully)?

pinging @Frizi for re-review (although no rush on finishing the review)

@somebody1234 somebody1234 mentioned this pull request Dec 19, 2024
Draft
5 tasks
@somebody1234
Copy link
Contributor Author

my bad, overly eager moving into gui

@somebody1234 somebody1234 added CI: No changelog needed Do not require a changelog entry for this PR. g-dashboard x-refactor Changes that should not be visible to the end-user labels Dec 19, 2024
Frizi
Frizi requested changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@Frizi Frizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR needs to wait for bazel branch to be merged first. Otherwise we will have an immense amount of conflicts, and it is a priority to finish it first.

@somebody1234 somebody1234 marked this pull request as draft December 19, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazcw kazcw kazcw left review comments

@Frizi Frizi Frizi requested changes

@PabloBuchu PabloBuchu Awaiting requested review from PabloBuchu PabloBuchu is a code owner

@indiv0 indiv0 Awaiting requested review from indiv0 indiv0 is a code owner

@MrFlashAccount MrFlashAccount Awaiting requested review from MrFlashAccount MrFlashAccount is a code owner

@farmaazon farmaazon Awaiting requested review from farmaazon farmaazon is a code owner

@vitvakatu vitvakatu Awaiting requested review from vitvakatu vitvakatu is a code owner

@AdRiley AdRiley Awaiting requested review from AdRiley AdRiley is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
CI: No changelog needed Do not require a changelog entry for this PR. g-dashboard x-refactor Changes that should not be visible to the end-user
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@somebody1234 @Frizi @kazcw