Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raiseAssertionPanic instead of shouldNotReachHere #11877

Merged
merged 1 commit into from
Dec 17, 2024
Merged

raiseAssertionPanic instead of shouldNotReachHere #11877

merged 1 commit into from
Dec 17, 2024

Conversation

JaroslavTulach
Copy link
Member

@JaroslavTulach JaroslavTulach commented Dec 16, 2024 •
edited
Loading

Pull Request Description

Fixes #11571 by ctx.raiseAssertionPanic and by type checking the parameter inline to get Type_Error.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • All code follows the
    Java,
  • Unit tests have been written where possible.

@JaroslavTulach JaroslavTulach added the CI: No changelog needed Do not require a changelog entry for this PR. label Dec 16, 2024
@JaroslavTulach JaroslavTulach self-assigned this Dec 16, 2024
@enso-bot enso-bot bot mentioned this pull request Dec 17, 2024
Closed
@JaroslavTulach JaroslavTulach merged commit 1df9ea6 into develop Dec 17, 2024
43 checks passed
@JaroslavTulach JaroslavTulach deleted the wip/jtulach/AssertionPanic11571 branch December 17, 2024 13:33
@enso-bot enso-bot bot mentioned this pull request Dec 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GregoryTravis GregoryTravis GregoryTravis approved these changes

@Akirathan Akirathan Akirathan approved these changes

@jdunkerley jdunkerley Awaiting requested review from jdunkerley jdunkerley is a code owner

@radeusgd radeusgd Awaiting requested review from radeusgd radeusgd is a code owner

@AdRiley AdRiley Awaiting requested review from AdRiley AdRiley is a code owner

@marthasharkey marthasharkey Awaiting requested review from marthasharkey marthasharkey is a code owner

@4e6 4e6 Awaiting requested review from 4e6 4e6 is a code owner

@hubertp hubertp Awaiting requested review from hubertp hubertp is a code owner

Assignees

@JaroslavTulach JaroslavTulach

Labels
CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Calling Warning.set with badly typed argument crashes interpreter
3 participants
@JaroslavTulach @Akirathan @GregoryTravis