-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add timeout for opening projects #11909
Merged
MrFlashAccount
merged 5 commits into
develop
from
wip/sergeigarin/open-project-timeouts
Dec 24, 2024
Merged
Add timeout for opening projects #11909
MrFlashAccount
merged 5 commits into
develop
from
wip/sergeigarin/open-project-timeouts
Dec 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrFlashAccount
added
CI: No changelog needed
Do not require a changelog entry for this PR.
g-dashboard
labels
Dec 18, 2024
🧪 Storybook is successfully deployed!📊 Dashboard:
|
MrFlashAccount
force-pushed
the
wip/sergeigarin/open-project-timeouts
branch
from
December 19, 2024 09:30
64611a8
to
5c84214
Compare
MrFlashAccount
requested review from
PabloBuchu,
indiv0 and
somebody1234
as code owners
December 19, 2024 14:06
Oh you right! Lets remove this for now |
@PabloBuchu ready for re-qa ✅ |
PabloBuchu
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Closes: https://github.com/enso-org/cloud-v2/issues/1628
This PR sets timeout for opening projects.
If a projects doesn't switch to the desired state (opened) withing the given time interval, we assume the Project is failed to open. We show and error ans ask user to restart
Also this PR sets timeout for all HTTP requests to 10 seconds.Removed, causes issues with some requestsTODO:
Tests. they're blocked by #11820 (this PR enables the Cloud execution)
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.