Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout for opening projects #11909

Merged
merged 5 commits into from
Dec 24, 2024

Conversation

MrFlashAccount
Copy link
Contributor

@MrFlashAccount MrFlashAccount commented Dec 18, 2024

Pull Request Description

Closes: https://github.com/enso-org/cloud-v2/issues/1628

This PR sets timeout for opening projects.

If a projects doesn't switch to the desired state (opened) withing the given time interval, we assume the Project is failed to open. We show and error ans ask user to restart

Also this PR sets timeout for all HTTP requests to 10 seconds. Removed, causes issues with some requests

TODO:
Tests. they're blocked by #11820 (this PR enables the Cloud execution)

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@MrFlashAccount MrFlashAccount self-assigned this Dec 18, 2024
@MrFlashAccount MrFlashAccount added CI: No changelog needed Do not require a changelog entry for this PR. g-dashboard labels Dec 18, 2024
Copy link

github-actions bot commented Dec 18, 2024

🧪 Storybook is successfully deployed!

📊 Dashboard:

@MrFlashAccount MrFlashAccount force-pushed the wip/sergeigarin/open-project-timeouts branch from 64611a8 to 5c84214 Compare December 19, 2024 09:30
@MrFlashAccount MrFlashAccount marked this pull request as ready for review December 19, 2024 14:06
@PabloBuchu
Copy link
Contributor

| Also this PR sets timeout for all HTTP requests to 10 seconds.

some of them needs to have longer timeout:

  • get_project_details?presigned=true - it copes project files to tmp bucket and generates presigned url
  • get_file_detilas?presigned=true same as above but files
  • upload_file_end <- this has over 2 minute timeout on backend. for big files it is necessary
  • how about uploading chunks to s3. are we sure they will finish within 10seconds?
Screenshot 2024-12-20 at 15 21 09

@MrFlashAccount
Copy link
Contributor Author

| Also this PR sets timeout for all HTTP requests to 10 seconds.

Oh you right! Lets remove this for now

@MrFlashAccount
Copy link
Contributor Author

@PabloBuchu ready for re-qa ✅

@MrFlashAccount MrFlashAccount merged commit 910d5a7 into develop Dec 24, 2024
40 checks passed
@MrFlashAccount MrFlashAccount deleted the wip/sergeigarin/open-project-timeouts branch December 24, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. g-dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants