Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breadcrumbs component #12115

Merged
merged 10 commits into from
Jan 27, 2025
Merged

Breadcrumbs component #12115

merged 10 commits into from
Jan 27, 2025

Conversation

MrFlashAccount
Copy link
Contributor

@MrFlashAccount MrFlashAccount commented Jan 22, 2025 •
edited
Loading

Pull Request Description

This PR is a prerequisite for https://github.com/enso-org/cloud-v2/issues/1656
Closes: https://github.com/enso-org/cloud-v2/issues/1714

Please refer to storybook for visual review.

CleanShot 2025-01-24 at 14 05 17@2x

Features:

  1. Collapses intermediate elements into a menu
  2. Allows to add start and end addons (E.g. add a dropdown with actions)
  3. Displays icons
  4. Truncate long text and display a popup
  5. Can be disabled.
  6. Current page is not clickable.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 22, 2025 •
edited
Loading

🧪 Storybook is successfully deployed!

📊 Dashboard:

@MrFlashAccount MrFlashAccount changed the title Basic implementation of Breadcrumbs Breadcrumbs component Jan 24, 2025
@MrFlashAccount MrFlashAccount self-assigned this Jan 24, 2025
@MrFlashAccount MrFlashAccount added --breaking Important: a change that will break a public API or user-facing behaviour CI: No changelog needed Do not require a changelog entry for this PR. x-new-feature Type: new feature request g-dashboard and removed --breaking Important: a change that will break a public API or user-facing behaviour labels Jan 24, 2025
@MrFlashAccount MrFlashAccount marked this pull request as ready for review January 24, 2025 10:08
@mergify mergify bot mentioned this pull request Jan 24, 2025
Draft
5 tasks
@MrFlashAccount MrFlashAccount added CI: Keep up to date Automatically update this PR to the latest develop. CI: Ready to merge This PR is eligible for automatic merge labels Jan 25, 2025
@MrFlashAccount MrFlashAccount force-pushed the wip/sergeigarin/breadcrumbs branch from de15442 to 0c4fd3d Compare January 27, 2025 06:25
@MrFlashAccount MrFlashAccount removed the CI: Keep up to date Automatically update this PR to the latest develop. label Jan 27, 2025
vitvakatu
vitvakatu approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@vitvakatu vitvakatu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM owned changes

@MrFlashAccount MrFlashAccount force-pushed the wip/sergeigarin/breadcrumbs branch from a8119b0 to 59836a7 Compare January 27, 2025 09:35
@mergify mergify bot merged commit 08ecd3d into develop Jan 27, 2025
39 of 42 checks passed
@mergify mergify bot deleted the wip/sergeigarin/breadcrumbs branch January 27, 2025 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitvakatu vitvakatu vitvakatu approved these changes

@PabloBuchu PabloBuchu PabloBuchu approved these changes

@AdRiley AdRiley AdRiley approved these changes

@Frizi Frizi Awaiting requested review from Frizi Frizi is a code owner

@farmaazon farmaazon Awaiting requested review from farmaazon farmaazon is a code owner

@kazcw kazcw Awaiting requested review from kazcw kazcw is a code owner

@indiv0 indiv0 Awaiting requested review from indiv0 indiv0 is a code owner

@somebody1234 somebody1234 Awaiting requested review from somebody1234 somebody1234 is a code owner

@jdunkerley jdunkerley Awaiting requested review from jdunkerley jdunkerley is a code owner

@hubertp hubertp Awaiting requested review from hubertp hubertp is a code owner

Assignees

@MrFlashAccount MrFlashAccount

Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge g-dashboard x-new-feature Type: new feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MrFlashAccount @AdRiley @PabloBuchu @vitvakatu