Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use
BuiltinRootNode.ArgNode
to extract argument for a builtin method #12201Use
BuiltinRootNode.ArgNode
to extract argument for a builtin method #12201Changes from 30 commits
e261e8d
5847b0f
b646932
20fa9c3
731f3bb
ecb74c5
0925fa2
24fe8da
f60457c
feb75d0
8f652cb
01be17a
f0480f7
e2571a1
91d3584
847bd99
7be3262
d6d859a
4ca2226
13fc5fe
3579139
934deae
e3ee0ea
f211c19
54751cb
68a654b
7364a34
0a3ec13
21d9bc3
e6af654
560e6b7
5443128
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now we attempt to provide a
representationType
to eachBuiltin
. That way we can deduce from signature methods having argument likeboolean
that the desired builtin isBoolean
and the Enso type should beStandard.Base.Data.Boolean.Boolean
. With that information we can extract (viaCastToNode
) such a type fromEnsoMultiValue
....There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using
hasWarnings
here instead of simplewarnings instanceof WithWarnings
is causing problems:BuiltinRootNode.ArgNode
to extract argument for a builtin method #12201 (comment)Let's see what #12258 can do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first time
ArgNode
is requested to "cast", it searches for theensoType
representing the value of the argument. It would be better to do this when theArgNode
is being created, but it may be too early (beforeStandard.Base
types are loaded in), so I haven't even tried.Opinions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say we have way too many
Builtin
s. Not sure whyPolyglot
orDebug
should be builtin types at all!?