Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introducing Meta.Type #5956

Merged
merged 14 commits into from
Mar 17, 2023
Merged

Introducing Meta.Type #5956

merged 14 commits into from
Mar 17, 2023

Conversation

JaroslavTulach
Copy link
Member

@JaroslavTulach JaroslavTulach commented Mar 15, 2023 •
edited
Loading

Pull Request Description

Fixing #5768 and #5765 and co. Introducing Meta.Type and giving it the desired methods.

Important Notes

Type is no longer a Meta.Atom, but it has a dedicated Meta.Type representation.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • All code follows the
    Scala,
    Java,
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.

@JaroslavTulach JaroslavTulach self-assigned this Mar 15, 2023
@JaroslavTulach JaroslavTulach mentioned this pull request Mar 15, 2023
Merged
2 tasks
radeusgd
radeusgd approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@radeusgd radeusgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So glad that we are getting Meta.Type ❤️ it is so much cleaner IMO

Some suggestions above, once the tests are passing this will be great!

@enso-bot enso-bot bot mentioned this pull request Mar 16, 2023
Closed
@JaroslavTulach JaroslavTulach mentioned this pull request Mar 16, 2023
Closed
@JaroslavTulach JaroslavTulach changed the title Introducing Meta.Type and giving it constructors method Introducing Meta.Type Mar 17, 2023
This was linked to issues Mar 17, 2023
Access a type's method list through the Meta library #5765
Closed
Access a type's constructor list through the Meta lib #5768
Closed
hubertp
hubertp reviewed Mar 17, 2023
View reviewed changes
Copy link
Contributor

@hubertp hubertp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some documentation nits

distribution/lib/Standard/Base/0.0.0-dev/src/Meta.enso Show resolved Hide resolved
distribution/lib/Standard/Base/0.0.0-dev/src/Meta.enso Outdated Show resolved Hide resolved
engine/runtime/src/main/java/org/enso/interpreter/node/expression/builtin/meta/IsTypeNode.java Show resolved Hide resolved
...me/src/main/java/org/enso/interpreter/node/expression/builtin/text/AnyToDisplayTextNode.java Outdated Show resolved Hide resolved
@JaroslavTulach JaroslavTulach added the CI: Ready to merge This PR is eligible for automatic merge label Mar 17, 2023
@mergify mergify bot merged commit b46be10 into develop Mar 17, 2023
@mergify mergify bot deleted the wip/jtulach/MetaType_5768 branch March 17, 2023 20:08
@enso-bot enso-bot bot mentioned this pull request Mar 18, 2023
Closed
@JaroslavTulach JaroslavTulach mentioned this pull request Mar 29, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radeusgd radeusgd radeusgd approved these changes

@hubertp hubertp hubertp approved these changes

@jdunkerley jdunkerley Awaiting requested review from jdunkerley jdunkerley is a code owner

@4e6 4e6 Awaiting requested review from 4e6 4e6 is a code owner

@kustosz kustosz Awaiting requested review from kustosz

Assignees

@JaroslavTulach JaroslavTulach

Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Access a type's constructor list through the Meta lib Access a type's method list through the Meta library
3 participants
@JaroslavTulach @hubertp @radeusgd