Reduce draw calls #6707
Reduce draw calls #6707
Conversation
kazcw
requested review from
MichaelMauderer,
wdanilo and
farmaazon
as code owners
kazcw
added
the
CI: No changelog needed
|
I'll be testing this some more in the morning (with a Book Club), but it's ready for review. |
| source_width: default(), | ||
| source_height: default(), | ||
| target_position: default(), | ||
| target_attached: default(), | ||
| color: default(), | ||
| sections: default(), | ||
| split_arc: default(), | ||
| hover_sections: default(), | ||
| corner_points: default(), | ||
| target_attachment: default(), | ||
| hover_position: default(), | ||
| disabled: default(), | ||
| previous_target: default(), | ||
| previous_is_hoverable: default(), | ||
| previous_hover_split: default(), | ||
| previous_color: default(), | ||
| previous_target_attached: default(), |
There was a problem hiding this comment.
I wonder if using ..default() is reasonable here.
There was a problem hiding this comment.
I wish I could do it that way, but I can't impl Default for EdgeModel because it must hold a Scene, so I can't default-construct an EdgeModel object to use for field-update syntax.
There was a problem hiding this comment.
We could split this into two structs and deref to the inner struct, making the inner struct Default. I'm not sure though if we want it. Up to you :)
| $(output.push(&self.$field);)* | ||
| output | ||
| } | ||
| fn source_x_range(&self) -> f32 { |
There was a problem hiding this comment.
What is source_x_range? I'd expect Range<f32> as the return type for anything with range in the name.
|
There's a flicker when the mouse enters/leaves the arc area of a corner, caused by an existing bug. Issue: #6717 |
|
Updated demo; the old edges are in red: vokoscreenNG-2023-06-01_16-37-03.webmKnown differences:
|
| //! # Partial edges | ||
| //! | ||
| //! Corners are sufficient to draw any complete edge; however, in order to split an edge into a | ||
| //! focused portion and an unfocused portion at an arbitrary location based on the mouse position, | ||
| //! we need to subdivide one of the corners of the edge. | ||
| //! | ||
| //! |\ | ||
| //! | 3 | ||
| //! / |
|
QA: passed 📗 |
Pull Request Description
Implements #6544 (eliminates 10/42 of the constantly-displayed draw calls).
Fixes #6717. Improves startup CPU time by 5% (250ms, loading Orders on my dev box).
Important Notes
Rectangleto display triangles.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.