Renaming Variable or Function Support #7515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engine/runtime/src/main/scala/org/enso/compiler/refactoring/IRUtils.scala
Outdated
Show resolved
Hide resolved
hubertp
approved these changes
Aug 9, 2023
| jobControlPlane = jobExecutionEngine, | ||
| locking = locking, | ||
| state = executionState, | ||
| versionCalculator = Sha3_224VersionCalculator |
There was a problem hiding this comment.
We really should avoid using sha3, seems like an overkill, but I know that it is used in other places as well. Probably a separate ticket.
| } | ||
|
|
||
| /** | ||
| * @return {@code true} if the provided name is a valid identifier of an Enso method and {@code |
There was a problem hiding this comment.
"of an Enso method" is this only validating method names or just symbols' names in general?
There was a problem hiding this comment.
It validates names that appear on the left-hand side of the assignment. Type name can be also called an identifier (but it should be an uppercase), so I preferred to specify.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
close #7389
Changelog:
refactoring/renameSymbolrequest to rename locals or module methodsImportant Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.