Use TruffleLogger bound to the engine to prevent illegal usage #8169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hubertp
added
the
CI: No changelog needed
hubertp
commented
Oct 30, 2023
| private final RuntimeStubsGenerator stubsGenerator; | ||
|
|
||
| TruffleCompilerContext(EnsoContext context) { | ||
| this.context = context; | ||
| this.compiler = context.getLogger(Compiler.class); | ||
| this.serializationManager = context.getLogger(SerializationManager.class); | ||
| this.compilerLogger = context.getLogger(Compiler.class); |
There was a problem hiding this comment.
I left this logger as-is as I haven't seen the same illegal state failures as with SerializationManager, potentially because (de-)serializationis is typically run in a separate thread. We could change it as well, I'm open for suggestions.
There was a problem hiding this comment.
I think we want to bound all loggers to engine. No need to have two getLogger and getLoggerBoundToEngine method.
hubertp
changed the title
hubertp
changed the title
| private final RuntimeStubsGenerator stubsGenerator; | ||
|
|
||
| TruffleCompilerContext(EnsoContext context) { | ||
| this.context = context; | ||
| this.compiler = context.getLogger(Compiler.class); | ||
| this.serializationManager = context.getLogger(SerializationManager.class); | ||
| this.compilerLogger = context.getLogger(Compiler.class); |
There was a problem hiding this comment.
I think we want to bound all loggers to engine. No need to have two getLogger and getLoggerBoundToEngine method.
engine/runtime/src/main/java/org/enso/interpreter/runtime/EnsoContext.java
Show resolved
Hide resolved
engine/runtime/src/main/java/org/enso/interpreter/runtime/EnsoContext.java
Outdated
Show resolved
Hide resolved
...uments/src/test/java/org/enso/interpreter/test/instrument/AvoidIdInstrumentationTagTest.java
Show resolved
Hide resolved
Partial fix for Truffle logger crashes - context required log levels. With a suggested change of log level in `SerializationManager` `sbt:enso> runtime/testOnly *SerdeCompilerTest` now passes but `sbt:enso> runtime/test` ...will continue to fail in `SerdeCompilerTest`, which is really confusing.
TruffleLoggers bound to the context were problematic when being invoked in threads coming from a thread pool. By explicitly using a TruffleLogger that is bound to the engine we can prevent such illegal usage.
Logs were often sent to null outpu stream or `ByteArrayOutputStream`, ending up in a black hole. We want to see the logs above the specific level because they are relevant to debugging problems.
hubertp
force-pushed
the
wip/hubert/8147-truffle-logger-crash
branch
from
9fc5834 to
6bb7a45
Compare
JaroslavTulach
approved these changes
Oct 31, 2023
engine/runtime/src/main/java/org/enso/interpreter/runtime/EnsoContext.java
Show resolved
Hide resolved
Akirathan
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Using a
TruffleLoggerinSerializationManagerthat is bound to the engine rather than the context prevents reaching an illegal state when using thread pools.Also cleaned up some tests for consistency.
To verify the fix
and run
sbt:enso> runtime/testCloses #8147.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.