Eliminate references to Truffle nodes & co. in the compiler #8172
Conversation
JaroslavTulach
added
the
CI: No changelog needed
JaroslavTulach
requested review from
4e6,
hubertp and
Akirathan
as code owners
| @@ -34,8 +34,6 @@ import org.enso.compiler.phase.{ | |||
| ImportResolver | |||
| } | |||
| import org.enso.editions.LibraryName | |||
| import org.enso.interpreter.node.{ExpressionNode => RuntimeExpression} | |||
| import org.enso.interpreter.runtime.scope.ModuleScope | |||
There was a problem hiding this comment.
No more Node and ModuleScope referenced in the compiler.
| import org.enso.interpreter.runtime.data.Type; | ||
| import org.enso.interpreter.runtime.scope.LocalScope; | ||
| import org.enso.interpreter.runtime.scope.ModuleScope; |
There was a problem hiding this comment.
No more scopes and ExpressionNode in the CompilerContext.
| @@ -1,7 +1,8 @@ | |||
| package org.enso.compiler.codegen | |||
| package org.enso.interpreter.runtime | |||
There was a problem hiding this comment.
IrToTruffle moves next to TruffleCompilerContext implementation as it is runtime related - not compile (e.g. IR processing) time related activity.
|
With latest changes (8477a78b54) there are only few remaining references to interpreter in the IR compiler Scala package:
Chances are that soon (in another PR) we might be able to create |
| @@ -2228,4 +2275,13 @@ class IrToTruffle( | |||
| ) | |||
| } | |||
| } | |||
|
|
|||
| private def asScope(module: CompilerContext.Module): ModuleScope = { | |||
There was a problem hiding this comment.
nit: as suggests that we have some casting involved, get or infer would seem to suggest that we get the scope for the given module.
There was a problem hiding this comment.
some casting involved
In such case I have chosen the right name. There is casting hidden in fromCompilerModule and it could fail if some non-TruffleCompilerContext.Module is passed in.
Pull Request Description
Work on #6100 has resulted in additional cleanups & refactorings of the Enso
Compiler&CompilerContextabstraction.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,