Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use DELETE /assets/<id> for deleting files and secrets #9551

Merged
merged 3 commits into from
Mar 26, 2024
Merged

Use DELETE /assets/<id> for deleting files and secrets #9551

merged 3 commits into from
Mar 26, 2024

Conversation

radeusgd
Copy link
Member

Pull Request Description

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@radeusgd radeusgd added the CI: No changelog needed Do not require a changelog entry for this PR. label Mar 26, 2024
@radeusgd radeusgd self-assigned this Mar 26, 2024
@radeusgd radeusgd added the CI: Ready to merge This PR is eligible for automatic merge label Mar 26, 2024
@mergify mergify bot merged commit 431a055 into develop Mar 26, 2024
43 checks passed
@mergify mergify bot deleted the wip/radeusgd/9288-update-delete-asset-endpoint branch March 26, 2024 21:48
@enso-bot enso-bot bot mentioned this pull request Mar 27, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GregoryTravis GregoryTravis GregoryTravis approved these changes

@jdunkerley jdunkerley jdunkerley approved these changes

@AdRiley AdRiley AdRiley approved these changes

Assignees

@radeusgd radeusgd

Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use DELETE /assets/<id> for removing Enso_File assets
4 participants
@radeusgd @AdRiley @jdunkerley @GregoryTravis