-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add table running functionality for Sum, Mean, Min, Max. #9577
Merged
AdRiley
merged 4 commits into
develop
from
wip/adr/add-more-table-running-functionality
Apr 23, 2024
Merged
Add table running functionality for Sum, Mean, Min, Max. #9577
AdRiley
merged 4 commits into
develop
from
wip/adr/add-more-table-running-functionality
Apr 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdRiley
force-pushed
the
wip/adr/add-more-table-running-functionality
branch
2 times, most recently
from
April 17, 2024 15:10
09d438c
to
ae90090
Compare
AdRiley
changed the title
Wip/adr/add more table running functionality
Add table running functionality for Sum, Mean, Min, Max.
Apr 18, 2024
AdRiley
requested review from
jdunkerley,
radeusgd and
GregoryTravis
as code owners
April 18, 2024 10:58
jdunkerley
reviewed
Apr 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think looks good - like to think through how we can support different result value types for min/max.
distribution/lib/Standard/Base/0.0.0-dev/src/Data/Statistics.enso
Outdated
Show resolved
Hide resolved
distribution/lib/Standard/Base/0.0.0-dev/src/Data/Statistics.enso
Outdated
Show resolved
Hide resolved
distribution/lib/Standard/Table/0.0.0-dev/src/Internal/Add_Running.enso
Outdated
Show resolved
Hide resolved
AdRiley
force-pushed
the
wip/adr/add-more-table-running-functionality
branch
from
April 19, 2024 08:03
6108188
to
0f3c33d
Compare
radeusgd
reviewed
Apr 19, 2024
distribution/lib/Standard/Table/0.0.0-dev/src/Internal/Add_Running.enso
Outdated
Show resolved
Hide resolved
radeusgd
reviewed
Apr 19, 2024
radeusgd
reviewed
Apr 19, 2024
jdunkerley
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Complete Table.Running for Sum, Mean, Min, Max.
Variance, SD, Skew and Kurtosis will be a follow on PR as this one is already quite big.
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build
.