Use proper Java class name in error message #9996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaroslavTulach
added
the
CI: No changelog needed
JaroslavTulach
commented
May 18, 2024
| fail("Unexpected result: " + never); | ||
| } catch (PolyglotException ex) { | ||
| assertEquals( | ||
| "Method `invoke` of type java.lang.Runnable could not be found.", ex.getMessage()); |
There was a problem hiding this comment.
The previous error was:
"Method `invoke` of type Class could not be found.
which is not very useful.
Akirathan
approved these changes
May 20, 2024
engine/runtime-integration-tests/src/test/java/org/enso/compiler/ExecCompilerTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Pavel Marek <pavel.marek@enso.org>
JaroslavTulach
added
the
CI: Ready to merge
hubertp
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Better error message when static method cannot be found on a Java class.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Java,