Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENG-1666: Explicitly add the "/api" path prefix to the FE api call #119

Merged
merged 2 commits into from
Dec 29, 2020
Merged

ENG-1666: Explicitly add the "/api" path prefix to the FE api call #119

merged 2 commits into from
Dec 29, 2020

Conversation

w-caffiero-entando
Copy link
Contributor

No description provided.

@w-caffiero-entando w-caffiero-entando changed the title ENG-1666: Explicitly add the "/api" suffix to the FE api call ENG-1666: Explicitly add the "/api" prefix to the FE api call Dec 28, 2020
@w-caffiero-entando w-caffiero-entando changed the title ENG-1666: Explicitly add the "/api" prefix to the FE api call ENG-1666: Explicitly add the "/api" path prefix to the FE api call Dec 28, 2020
@avdev4j
Copy link
Contributor

avdev4j commented Dec 28, 2020 •
edited
Loading

Should we change the .ftl files too?
example:
https://github.com/entando/entando-blueprint/blob/master/generators/entity-server/templates/ui/widgets/detailsWidget/bundle/details-widget.ftl.ejs#L6

@w-caffiero-entando
Copy link
Contributor Author

w-caffiero-entando commented Dec 28, 2020 •
edited
Loading

Should we change the .ftl files too?
example:
https://github.com/entando/entando-blueprint/blob/master/generators/entity-server/templates/ui/widgets/detailsWidget/bundle/details-widget.ftl.ejs#L6

@avdev4j When the bundle is packaged that /api disappears because the value of the service-url is set by the build script. That's in fact the issue that started the discussion in the first place. However it makes sense, so I'll do it

@w-caffiero-entando w-caffiero-entando marked this pull request as ready for review December 29, 2020 12:46
@w-caffiero-entando w-caffiero-entando merged commit c34b145 into master Dec 29, 2020
@w-caffiero-entando w-caffiero-entando deleted the ENG-1666-when-deployed-a-widget-mfe-fails-because-its-not-calling-the-correct-microservice-endpoint branch December 29, 2020 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avdev4j avdev4j avdev4j approved these changes

@gidesan gidesan Awaiting requested review from gidesan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@w-caffiero-entando @avdev4j