This repository has been archived by the owner on May 14, 2024. It is now read-only.
Migrate to emotion #992
Merged
Migrate to emotion #992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
65a552a
|
| Status: | ⚡️ Build in progress... |
vishnukvmd
reviewed
Mar 25, 2023
vishnukvmd
approved these changes
Mar 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Facing issues, with
styled-component, not properly rendering styles and styles randomly breaking at various instances.Found an open issue on mui (mui/material-ui#29742), related similar issue.
migrated to use emotion.
Test Plan
opening /gallery directly on https://share-screen.bada-frame.pages.dev/gallery was causing rendering issues with the collection sort option
doing the same on https://migrate-to-emotion.bada-frame.pages.dev/gallery, is working without issues