Fix Tests' AttributeError in Python 3.9 with base64.decodestring #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
base64.decodestring is deprecated in 3.1, and has been an alias of decodebytes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #209
base64.decodestringis deprecated in 3.1, and has been an alias of decodebytesI searched the code base of apptools and it has only been used in tests. This PR fixes that particular tests.
Since we don't yet run against Python 3.9 on CI, I ran the test suite locally to verify it passes on Python 3.9 and OSX.
Checklist
While this may not be news worthy for developers using apptools, this is perhaps news worthy for distribution packagers who run package test suites against their systems (that is, if they also have all the optional dependencies e.g. pytables, but that is an orthogonal issue.)