Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove NullHandler from apptools.logger #216

Merged
merged 2 commits into from
Nov 17, 2020
Merged

Remove NullHandler from apptools.logger #216

merged 2 commits into from
Nov 17, 2020

Conversation

aaronayres35
Copy link
Contributor

@aaronayres35 aaronayres35 commented Nov 16, 2020 •
edited
Loading

fixes #213

As mentioned on the issue it is now available from the standard library. This PR simply deletes the null_handler module and removes the NullHandler import from apptools.logger.api

Checklist

  • Add a news fragment if this PR is news-worthy for end users. (see docs/releases/README.rst)

rahulporuri
rahulporuri approved these changes Nov 17, 2020
View reviewed changes
Copy link
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aaronayres35 aaronayres35 merged commit 6dfca82 into master Nov 17, 2020
@aaronayres35 aaronayres35 deleted the remove-null-handler branch November 17, 2020 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahulporuri rahulporuri rahulporuri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove apptools.logger.null_handler
2 participants
@aaronayres35 @rahulporuri