Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove FilteringHandler and apptools.logger.util.py #217

Merged
merged 3 commits into from
Nov 17, 2020
Merged

remove FilteringHandler and apptools.logger.util.py #217

merged 3 commits into from
Nov 17, 2020

Conversation

aaronayres35
Copy link
Contributor

@aaronayres35 aaronayres35 commented Nov 16, 2020 •
edited
Loading

fixes #212

As described in the issue, FilteringHandler does not look like it would work as expected, and there are no apparent downstream usage. Further, FilteringHandler was the only place where something from apptools.logger.util.py was called. The majority of the code in apptools.logger.util.py was also labelled as WIP. This PR deletes both the apptools.logger.filtering_handler.py and apptools.logger.util.py modules.

Checklist

  • Add a news fragment if this PR is news-worthy for end users. (see docs/releases/README.rst)

rahulporuri
rahulporuri approved these changes Nov 17, 2020
View reviewed changes
Copy link
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aaronayres35 aaronayres35 merged commit 5be6e44 into master Nov 17, 2020
@aaronayres35 aaronayres35 deleted the remove-FilteringHandler branch November 17, 2020 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahulporuri rahulporuri rahulporuri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

apptools.logger.filtering_handler.FilteringHandler can be removed
2 participants
@aaronayres35 @rahulporuri