Final flake8 fixes #239
Merged
Final flake8 fixes #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com>
…into final-flake8
rahulporuri
approved these changes
Nov 25, 2020
Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #145
After this PR, the
setup.cfgexclude section is entirely empty. We still have the per-file-ignores for F401 errors inapiand__init__files which should stay. We also still ignore E266 and W503 errors but I believe that is intended to remain the case.Checklist
- [ ] Add a news fragment if this PR is news-worthy for end users. (see docs/releases/README.rst)