-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove image license files #262
Conversation
I'd actually recommend moving the internal image license file - https://github.com/enthought/apptools/blob/master/apptools/logger/plugin/view/images/image_LICENSE.txt - to the top level, and including that in the manifest file. Also, I don't know what |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM
@aaronayres35 i'm not sure where you got the |
Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com>
@rahulporuri I found it in |
* remove image license files * move internal image license file to root directory * add image_LICENSE_CP.txt and include it in manifest * Apply suggestions from code review Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com> Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com>
* Make sure optional dependencies are optional for tests (#260) * make sure optional dependencies are optional for tests * add a news fragment * apply suggestion from code review * Add extras_require to setup.py for optional dependencies (#257) * add optional dependencies for specific cub packages to extras_require * add details to README about optional dependencies * list io imports as standard library imports * add prefrences/configobj to extras_rrequire as well (leave configobj in install_requires too) * add specific install instructions * formatting * remove unneeded back ticks * move install instructions into a separate section * add news fragment * add PR number to news fragment * Remove image license files (#262) * remove image license files * move internal image license file to root directory * add image_LICENSE_CP.txt and include it in manifest * Apply suggestions from code review Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com> Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com> * Add a new category for build system related changes (#261) * update changelog Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com> Co-authored-by: Kit Choi <kitchoi@users.noreply.github.com>
* Make sure optional dependencies are optional for tests (#260) * make sure optional dependencies are optional for tests * add a news fragment * apply suggestion from code review * Add extras_require to setup.py for optional dependencies (#257) * add optional dependencies for specific cub packages to extras_require * add details to README about optional dependencies * list io imports as standard library imports * add prefrences/configobj to extras_rrequire as well (leave configobj in install_requires too) * add specific install instructions * formatting * remove unneeded back ticks * move install instructions into a separate section * add news fragment * add PR number to news fragment * Remove image license files (#262) * remove image license files * move internal image license file to root directory * add image_LICENSE_CP.txt and include it in manifest * Apply suggestions from code review Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com> Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com> * Add a new category for build system related changes (#261) * update changelog Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com> Co-authored-by: Kit Choi <kitchoi@users.noreply.github.com>
fixes #236
The issue was motivated by this comment: #233 (comment)
Note, in making this PR I did noticed there is still one images directory in
apptools
: https://github.com/enthought/apptools/tree/master/apptools/logger/plugin/view/imagesbut it has its own
image_LICENSE.txt
file: https://github.com/enthought/apptools/blob/master/apptools/logger/plugin/view/images/image_LICENSE.txtThis PR also removes the deleted files from the
MANIFEST.in
file.Checklist