Replace on_trait_change with observe #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulporuri
approved these changes
Mar 31, 2021
| @@ -121,7 +121,7 @@ def _initialize(self): | |||
| """ Wire-up trait change handlers etc. """ | |||
|
|
|||
| # Listen for the object's trait being changed. | |||
| self.obj.on_trait_change(self._on_trait_changed, self.trait_name) | |||
| self.obj.observe(self._on_trait_changed, self.trait_name) | |||
There was a problem hiding this comment.
looks like we don't have a good place to unhook this listener
There was a problem hiding this comment.
yeah I noticed this as well... not sure what the best thing to do is
|
Orthogonal to this PR, but we should add a "maintenance" news fragment type. I wasn't sure which of "feature, bugfix, deprecation, removal, doc, test, build" to classify this PR as, but it feels like it will be ultimately relevant for the changelog (as I imagine 5.1 of apptools main purpose will be this migration to observe / depending on traits 6.2) I am going to call it a feature for now simply because IDK where to put it. When generating the actual changelog we will want to move this, but this way it will still be picked up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
This PR replaces almost all uses of
on_trait_changewith observe.All that remains is
apptools.selection.selection_service.pyandapptools.scripting.recorder.py(also an undo example but that is deprecated here anyway). These are a bit trickier and can be addressed separately