Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix IPersist.GetClassID to TYPE_CHECKING only method from Callable annotation #451

Merged
merged 2 commits into from
Jan 4, 2023
Merged

fix IPersist.GetClassID to TYPE_CHECKING only method from Callable annotation #451

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2303c65
fix `IPersist.GetClassID` to `TYPE_CHECKING` only
junkmd Jan 4, 2023
48d2d23
add comments
junkmd Jan 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions comtypes/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -857,9 +857,12 @@ class IPersist(IUnknown):
COMMETHOD([], HRESULT, "GetClassID", (["out"], POINTER(GUID), "pClassID")),
]
if TYPE_CHECKING:
# Returns the CLSID that uniquely represents an object class that
# defines the code that can manipulate the object's data.
GetClassID: Callable[[], GUID]
# Should this be "normal" method that calls `self._GetClassID`?
def GetClassID(self) -> GUID:
"""Returns the CLSID that uniquely represents an object class that
defines the code that can manipulate the object's data.
"""
...


class IServiceProvider(IUnknown):
Expand Down