Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove single_project #331

Merged
merged 1 commit into from
Oct 21, 2020
Merged

Remove single_project #331

merged 1 commit into from
Oct 21, 2020

Conversation

mdickinson
Copy link
Member

We've discussed this to death many times already, but single_project should go. It's unmaintained and has a number of serious issues.

Closes #327

rahulporuri
rahulporuri approved these changes Oct 21, 2020
View reviewed changes
Copy link
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdickinson mdickinson merged commit 2dc80c1 into master Oct 21, 2020
@mdickinson mdickinson deleted the cln/remove-single-project branch October 21, 2020 11:17
@rahulporuri
Copy link
Contributor

also closes #269

@rahulporuri rahulporuri mentioned this pull request Oct 21, 2020
Closed
@aaronayres35 aaronayres35 mentioned this pull request Nov 10, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahulporuri rahulporuri rahulporuri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider removing envisage.ui.single_project
2 participants
@mdickinson @rahulporuri