Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX : Pin sphinx version to get docs to build #1276

Merged
merged 2 commits into from
Aug 13, 2020
Merged

Conversation

rahulporuri
Copy link
Contributor

For reasons which i'm not sure of, sphinx 2.3.1 works but sphinx 3.2.0 which is the latest version available on pypi doesn't work.

fixes #1273

Checklist
- [ ] Tests
- [ ] Update API reference (docs/source/traits_api_reference)
- [ ] Update User manual (docs/source/traits_user_manual)
- [ ] Update type annotation hints in traits-stubs

for reasons which im not sure of, sphinx 2.3.1 works but sphinx 3.2.0
which is the latest version available on pypi doesn't work

	modified:   etstool.py
	modified:   setup.py
setup.py Outdated Show resolved Hide resolved
	modified:   etstool.py
	modified:   setup.py
Copy link
Contributor

@kitchoi kitchoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@rahulporuri rahulporuri merged commit ba50379 into master Aug 13, 2020
@rahulporuri rahulporuri deleted the fix/docs-build branch August 13, 2020 15:55
@kitchoi kitchoi restored the fix/docs-build branch August 14, 2020 16:31
@kitchoi kitchoi deleted the fix/docs-build branch August 14, 2020 16:32
mdickinson added a commit that referenced this pull request Oct 21, 2020
* Correct the minimum Sphinx version in README

We require Sphinx >= 2.1.

Related: #1216.

* Restore minimum version for Sphinx; see #1216 and #1276
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation build failure on CI
2 participants