Better formatting? #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set max_width = 120 (default: 100) Set use_small_heuristics = "Max"
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #51 +/- ##
==========================================
+ Coverage 99.34% 99.37% +0.02%
==========================================
Files 9 9
Lines 1382 1285 -97
==========================================
- Hits 1373 1277 -96
+ Misses 9 8 -1 ☔ View full report in Codecov by Sentry. |
fjarri
reviewed
Oct 7, 2024
|
Yes, of these three I think I prefer the 120 width and default heuristics variant too. I have some reluctance towards going against the all default settings, but line length is really the least obtrusive one. |
|
We should probably merge this when the other PRs are all merged. |
|
Ok, let's do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a rustfmt.toml and set max_width = 120 (default: 100) and use_small_heuristics = "Max"
I made a few variants for comparison:
max_width = 120+use_small_heuristics = "Max"max_width = 120+use_small_heuristics = "Default"max_width = 100+use_small_heuristics = "MaxI committed my personal preference as the last one: 120 width and default heuristics.