[entry2-web/2745] 네비게이션 탭에 따라 페이지가 달라지도록 수정 #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- '온라인 작품 불러오기' > '관심 작품' 에서 안내 코멘트를 변경 - 선택된 네비게이션 타입 정보 type(selected)를 Popup > Projects 컴포넌트에서 Popup > Projects > EmptyContents 컴포넌트로도 props로 전달. - 전달된 type정보를 기반으로 각기 다른 멘트가 출력되도록 로직 수정 - '작품 만들기' 버튼 삭제 - 전달된 type정보를 기반으로 'favorites' 타입일 경우 버튼을 렌더링하지 않도록 수정
Tnks2U
changed the title
kimorkim
reviewed
May 26, 2021
src/components/popup/index.jsx
Outdated
| @@ -118,6 +118,8 @@ class Popup extends Component { | |||
| break; | |||
| } | |||
| case 'projects': | |||
| view = <Projects type={selected} data={data} />; | |||
selected가 'project'일때와 'favorites'일때를 아직은 굳이 구분할 필요가 없을 것 같아 재수정하였습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
entry2-web 2745대응