Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

이슈 2427 처리 #2070

Merged
merged 2 commits into from
May 21, 2021
Merged

이슈 2427 처리 #2070

merged 2 commits into from
May 21, 2021

Conversation

wodnjs6512
Copy link
Contributor

@wodnjs6512 wodnjs6512 requested review from kimorkim and leunge May 11, 2021 09:08
@wodnjs6512 wodnjs6512 self-assigned this May 11, 2021
@github-actions github-actions bot added the issue 내부 이슈 처리를 위한 PR label May 11, 2021
kimorkim
kimorkim approved these changes May 12, 2021
View reviewed changes
Copy link
Collaborator

@kimorkim kimorkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

근데 궁금한게.
entryjs에는 optional chaining 사용이 안되었던가요?
optional chaining로 치환이 가능한 녀석들이 보여서요.

@wodnjs6512
Copy link
Contributor Author

wodnjs6512 commented May 18, 2021 •
edited
Loading

@kimorkim
babel세팅에서 plugin이 없어서 적용이 안되어있는줄 알았는데, babel-preset-env에 아예 포함이 되어있다고 하네요 변경해두겠습니다!

@leunge leunge merged commit 787f85f into develop May 21, 2021
@leunge leunge deleted the issue/2427 branch May 21, 2021 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimorkim kimorkim kimorkim approved these changes

@leunge leunge leunge approved these changes

Assignees

@wodnjs6512 wodnjs6512

Labels
issue 내부 이슈 처리를 위한 PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wodnjs6512 @kimorkim @leunge