Upgrade firebase #462
Merged
Upgrade firebase #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This major includes a transition in the SDK to a modular style. This requires some refactoring of the code. This commit uses the compat version of firebase 9 which only requires updates of the import statements.
draperunner
approved these changes
Sep 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tjena!
Her skjer det litt av hvert. Hovefordelen med å oppgradere til firebase 9 skal være at det lar webpack (evt andre bundlere) droppe å ta med deler av koden som ikke brukes, som igjen vil gjøre appen vår mindre. Google tree-shaking, det gjorde i alle fall jeg. Rent praktisk vil det si at man i stedet for å importere firebase og dotte seg inn på hva enn man skal ha bare importerer de respektive funskjonene man trenger.
F. eks:
Bir til
Hvor auth er instansen som blir initialisert i
firebase-init.tsHvor stor forskjell utgjør dette?
Den nette sum av 32Kb aka at appen vår blir ca 1% mindre. Hvor imponerende dette er kan diskuteres, men det er i alle fall noe.
Gjerne test dere også at firebase-funksjonaliteten fortsatt fungerer som før i emulator.