Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: google related test fixtures #105

Merged
merged 8 commits into from
Nov 21, 2021
Merged

Fix: google related test fixtures #105

merged 8 commits into from
Nov 21, 2021

Conversation

yaronya
Copy link
Contributor

@yaronya yaronya commented Nov 21, 2021 •
edited
Loading

Tests has failed on validation since google tf plugin has been upgraded and we aren't fixing its version.

In this PR I've:

  1. Fixed version to in all test fixtures (to the LTS supported version per TF version)
  2. Removed the (unsupported anymore) bucket_policy_only attribute

@yaronya yaronya requested a review from a team November 21, 2021 12:14
@yaronya yaronya self-assigned this Nov 21, 2021
liranfarage89
liranfarage89 approved these changes Nov 21, 2021
View reviewed changes
Copy link

@liranfarage89 liranfarage89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@yaronya yaronya merged commit af05794 into master Nov 21, 2021
@yaronya yaronya deleted the fix-google-test-fixtures branch November 21, 2021 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liranfarage89 liranfarage89 liranfarage89 approved these changes

Assignees

@yaronya yaronya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yaronya @liranfarage89